lkml.org 
[lkml]   [2015]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: possible new false positive in checkpatch
From
On Mon, Sep 14, 2015 at 1:27 PM, Andy Whitcroft <apw@canonical.com> wrote:
>
> On Sat, Sep 12, 2015 at 03:13:31PM +0300, Tal Shorer wrote:
> > Since my last pull from upstream (today) , I started seeing some
> > checkpatch warnings regarding suspect code indent I believe are false
> > positive. Take this code for example:
> >
> > static int foo(void)
> > {
> > while (bar())
> > /* do nothing */;
> > }
> >
> > When running checkpath on it, the following warning is emitted:
> >
> > tal@tal:~/Dev/lfs/linux|0 $ scripts/checkpatch.pl -f ~/tmp/foo.c
> > WARNING: suspect code indent for conditional statements (8, 32)
> > #3: FILE: /home/tal/tmp/foo.c:3:
> > + while (bar())
> > + /* do nothing */;
> >
> > total: 0 errors, 1 warnings, 5 lines checked
> >
> > /home/tal/tmp/foo.c has style problems, please review.
> >
> > NOTE: If any of the errors are false positives, please report
> > them to the maintainer, see CHECKPATCH in MAINTAINERS.
> > tal@tal:~/Dev/lfs/linux|1 $
> >
> > Using my limited perl knowledge, I believe the lines causing this are
> > 3111-3133:
> > # remove inline comments
> > $s =~ s/$;/ /g;
> > $c =~ s/$;/ /g;
>
> Yes it feels like that should be eliding them completely, and likely any
> following space as well, something like this:
>
> $s =~ s/$;+\s*//g;
> $c =~ s/$;+\s*//g;
>
Replacing the problematic lines with these fixes the issue.
> > Introduced in commit 9f5af480f4554aac12e002b6f5c2b04895857700:
> > checkpatch: improve SUSPECT_CODE_INDENT test
> > Commenting out these lines removes the warning.
> >
> > This pattern exists in many places around the kernel source.
> > Is this the intended behavior?
>
> Seems wrong to me.
>
> -apw

Which git tree is checkpatch developed in? Linus's?


\
 
 \ /
  Last update: 2015-09-15 17:21    [W:0.081 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site