lkml.org 
[lkml]   [2015]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM
Date
-	pfn = PFN_DOWN(param1 & param2);
- if (!page_is_ram(pfn) || ((param2 & PAGE_MASK) != PAGE_MASK))
+ base_addr = param1 & param2;
+ size = (~param2) + 1;

We expect the user will supply us with param2 in the form 0xffffffff[fec8]00000
with various numbers of leading 'f' and trailing '0' ... but I don't think we actually
check that anywhere. But we have a bunch of places that assume it is OK, including
this new one.

It's time to fix that. Maybe even provide a default 0xfffffffffffff000 so I can save myself
some typing?

-Tony


\
 
 \ /
  Last update: 2015-10-26 17:41    [W:0.038 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site