lkml.org 
[lkml]   [2015]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM
From
Date
On Mon, 2015-10-26 at 16:46 +0000, Luck, Tony wrote:
> > + ((param2 & PAGE_MASK) != PAGE_MASK))
> > return -EINVAL;
> >
> > The 3rd condition check makes sure that the param2 mask is the page size or less. So,
> > I think we are OK on this.
>
> Oops. The original was even on the screen as part of the diff (which I signed off on
> just two years ago).
>
> I'd be happier if you made it the 1st condition though, so we skip calling
> region_intersects_*() with a nonsense "size" argument.

Agreed. I will send an updated patch 3/3 later today, "[PATCH v2 UPDATE-2 3/3]".

Thanks,
-Toshi



\
 
 \ /
  Last update: 2015-10-26 18:01    [W:0.027 / U:0.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site