Messages in this thread | | | Date | Mon, 26 Oct 2015 12:27:20 +0100 | From | Lars-Peter Clausen <> | Subject | Re: [alsa-devel] [PATCH v2] ASoC: wm9713: convert to regmap |
| |
On 10/24/2015 11:37 PM, Robert Jarzmik wrote: [...] > -static unsigned int ac97_read(struct snd_soc_codec *codec, > - unsigned int reg); > -static int ac97_write(struct snd_soc_codec *codec, > - unsigned int reg, unsigned int val);
For review purposes it would be helpful to split this into two patches. One performing the regmap conversion the other replacing ac97_read()/ac97_write() with the matching snd_soc_ calls (or snd_soc_update_bits).
> + snd_soc_codec_init_regmap(codec, regmap);
You need to call snd_soc_odec_exit_regmap() when the CODEC is unbound.
| |