lkml.org 
[lkml]   [2015]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/8] mfd: da9052: Simplify function return logic
On Tue, 29 Sep 2015, Javier Martinez Canillas wrote:

> The invoked functions already return zero on success or a negative
> errno code so there is no need to open code the logic in the caller.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/mfd/da9052-i2c.c | 6 +-----
> drivers/mfd/da9052-spi.c | 6 +-----
> 2 files changed, 2 insertions(+), 10 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/da9052-i2c.c b/drivers/mfd/da9052-i2c.c
> index 02887001e800..2697ffb08009 100644
> --- a/drivers/mfd/da9052-i2c.c
> +++ b/drivers/mfd/da9052-i2c.c
> @@ -174,11 +174,7 @@ static int da9052_i2c_probe(struct i2c_client *client,
> return ret;
> }
>
> - ret = da9052_device_init(da9052, id->driver_data);
> - if (ret != 0)
> - return ret;
> -
> - return 0;
> + return da9052_device_init(da9052, id->driver_data);
> }
>
> static int da9052_i2c_remove(struct i2c_client *client)
> diff --git a/drivers/mfd/da9052-spi.c b/drivers/mfd/da9052-spi.c
> index b5de8a6856c0..0f5e2c2858c1 100644
> --- a/drivers/mfd/da9052-spi.c
> +++ b/drivers/mfd/da9052-spi.c
> @@ -56,11 +56,7 @@ static int da9052_spi_probe(struct spi_device *spi)
> return ret;
> }
>
> - ret = da9052_device_init(da9052, id->driver_data);
> - if (ret != 0)
> - return ret;
> -
> - return 0;
> + return da9052_device_init(da9052, id->driver_data);
> }
>
> static int da9052_spi_remove(struct spi_device *spi)

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


\
 
 \ /
  Last update: 2015-10-01 09:41    [W:0.107 / U:0.720 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site