Messages in this thread | | | Date | Thu, 1 Oct 2015 08:20:22 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 6/8] mfd: da903x: Simplify function return logic |
| |
On Tue, 29 Sep 2015, Javier Martinez Canillas wrote:
> The invoked function already returns zero on success or a negative > errno code so there is no need to open code the logic in the caller. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > > drivers/mfd/da903x.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c > index ef7fe2ae2fa4..37e4426ef061 100644 > --- a/drivers/mfd/da903x.c > +++ b/drivers/mfd/da903x.c > @@ -532,11 +532,7 @@ static int da903x_probe(struct i2c_client *client, > return ret; > } > > - ret = da903x_add_subdevs(chip, pdata); > - if (ret) > - return ret; > - > - return 0; > + return da903x_add_subdevs(chip, pdata); > } > > static int da903x_remove(struct i2c_client *client)
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |