lkml.org 
[lkml]   [2015]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3.12 140/176] gpio: sysfs: fix gpio device-attribute leak
On Wed, Jan 28, 2015 at 03:29:30PM +0100, Jiri Slaby wrote:
> From: Johan Hovold <johan@kernel.org>
>
> 3.12-stable review patch. If anyone has any objections, please let me know.
>
> ===============
>
> commit 0915e6feb38de8d3601819992a5bd050201a56fa upstream.
>
> The gpio device attributes were never destroyed when the gpio was
> unexported (or on export failures).
>
> Use device_create_with_groups() to create the default device attributes
> of the gpio class device. Note that this also fixes the
> attribute-creation race with userspace for these attributes.
>
> Remove contingent attributes in export error path and on unexport.
>
> Fixes: d8f388d8dc8d ("gpio: sysfs interface")
> Signed-off-by: Johan Hovold <johan@kernel.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>

There was a mistake in the 3.14 (and 3.12) backport. A fixed v2 backport
has been posted in this thread:

https://marc.info/?l=linux-kernel&m=142241055931689&w=2

Johan


\
 
 \ /
  Last update: 2015-01-29 04:01    [W:0.688 / U:0.836 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site