lkml.org 
[lkml]   [2015]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 125/176] ARM: shmobile: sh73a0 legacy: Set .control_parent for all irqpin instances
    Date
    From: Geert Uytterhoeven <geert+renesas@glider.be>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit b0ddb319db3d7a1943445f0de0a45c07a7f3457a upstream.

    The sh73a0 INTC can't mask interrupts properly most likely due to a
    hardware bug. Set the .control_parent flag to delegate masking to the
    parent interrupt controller, like was already done for irqpin1.

    Without this, accessing the three-axis digital accelerometer ADXL345
    on kzm9g through /dev/input/event1 causes an interrupt storm, which
    requires a power-cycle to recover from.

    This was inspired by a patch for arch/arm/boot/dts/sh73a0.dtsi from
    Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>.

    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Fixes: 341eb5465f67437a ("ARM: shmobile: INTC External IRQ pin driver on sh73a0")
    Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    arch/arm/mach-shmobile/setup-sh73a0.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c
    index 22de17417fd7..a10565d720c5 100644
    --- a/arch/arm/mach-shmobile/setup-sh73a0.c
    +++ b/arch/arm/mach-shmobile/setup-sh73a0.c
    @@ -746,6 +746,7 @@ static struct platform_device ipmmu_device = {

    static struct renesas_intc_irqpin_config irqpin0_platform_data = {
    .irq_base = irq_pin(0), /* IRQ0 -> IRQ7 */
    + .control_parent = true,
    };

    static struct resource irqpin0_resources[] = {
    @@ -807,6 +808,7 @@ static struct platform_device irqpin1_device = {

    static struct renesas_intc_irqpin_config irqpin2_platform_data = {
    .irq_base = irq_pin(16), /* IRQ16 -> IRQ23 */
    + .control_parent = true,
    };

    static struct resource irqpin2_resources[] = {
    @@ -837,6 +839,7 @@ static struct platform_device irqpin2_device = {

    static struct renesas_intc_irqpin_config irqpin3_platform_data = {
    .irq_base = irq_pin(24), /* IRQ24 -> IRQ31 */
    + .control_parent = true,
    };

    static struct resource irqpin3_resources[] = {
    --
    2.2.2


    \
     
     \ /
      Last update: 2015-01-29 11:41    [W:3.824 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site