Messages in this thread | | | Date | Wed, 28 Jan 2015 23:21:03 +0800 | Subject | Re: [PATCH 4/5] sched/rt: Consider deadline tasks in cpupri_find() | From | Xunlei Pang <> |
| |
Hi Steven,
On 28 January 2015 at 07:04, Steven Rostedt <rostedt@goodmis.org> wrote: > On Tue, 27 Jan 2015 13:58:59 +0100 > Peter Zijlstra <peterz@infradead.org> wrote: > > >> Not a bad idea, Cc'ed Steve who likes to look after the RT bits, >> excessive quoting for him. > > Yep I do. > > >> > index ade2958..48c9576 100644 >> > --- a/kernel/sched/core.c >> > +++ b/kernel/sched/core.c >> > @@ -5652,6 +5652,8 @@ static int init_rootdomain(struct root_domain *rd) >> > >> > if (cpupri_init(&rd->cpupri) != 0) >> > goto free_rto_mask; >> > + >> > + rd->cpupri.cpudl = &rd->cpudl; >> >> This is disgusting though; it breaks the cpuri abstraction. Why not pass >> in the mask in the one place you actually need it? > > Yeah, probably should change cpupri_init() to take the rd->cpudl as a > parameter.
Ok, thanks for your advice. I'll refine this patch and send it out separately soon.
Thanks, Xunlei
> > Rest looks good (ignoring Peter's other comment that he realized wasn't > an issue). > > -- Steve >
| |