Messages in this thread | | | Date | Tue, 27 Jan 2015 18:04:38 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH 4/5] sched/rt: Consider deadline tasks in cpupri_find() |
| |
On Tue, 27 Jan 2015 13:58:59 +0100 Peter Zijlstra <peterz@infradead.org> wrote:
> Not a bad idea, Cc'ed Steve who likes to look after the RT bits, > excessive quoting for him.
Yep I do.
> > index ade2958..48c9576 100644 > > --- a/kernel/sched/core.c > > +++ b/kernel/sched/core.c > > @@ -5652,6 +5652,8 @@ static int init_rootdomain(struct root_domain *rd) > > > > if (cpupri_init(&rd->cpupri) != 0) > > goto free_rto_mask; > > + > > + rd->cpupri.cpudl = &rd->cpudl; > > This is disgusting though; it breaks the cpuri abstraction. Why not pass > in the mask in the one place you actually need it?
Yeah, probably should change cpupri_init() to take the rd->cpudl as a parameter.
Rest looks good (ignoring Peter's other comment that he realized wasn't an issue).
-- Steve
| |