lkml.org 
[lkml]   [2015]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [linux-sunxi] [PATCH v4 5/5] ARM: sunxi: dts: Add PS2 nodes for A20 lime2 board
On 16/01/15 14:03, Vishnu Patekar wrote:
> Signed-off-by: VishnuPatekar <vishnupatekar0510@gmail.com>
> ---
> arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> index ed364d5..3365f12 100644
> --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> @@ -113,6 +113,18 @@
> status = "okay";
> };
>
> + ps20: ps2@01c2a000 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&ps20_pins_a>;
> + status = "okay";
> + };
> +
> + ps21: ps2@01c2a400 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&ps21_pins_a>;
> + status = "okay";
> + };
> +
> i2c0: i2c@01c2ac00 {
> pinctrl-names = "default";
> pinctrl-0 = <&i2c0_pins_a>;
>

As the Lime2 doesn't actually have any PS2 connectors on the board,
I'd prefer that these are not enabled unconditionally. Doing so
only makes it more difficult for people who want to use these pins
for other functions.

Device tree overlays seem to be close to being merged, perhaps we
could leave enabling this to an overlay?


\
 
 \ /
  Last update: 2015-01-20 18:41    [W:0.250 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site