| Date | Tue, 2 Sep 2014 20:36:13 +0100 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH v11 07/19] irqchip: gic: Add support for FIQ management |
| |
On Tue, Sep 02, 2014 at 02:00:41PM +0100, Daniel Thompson wrote: > +static void gic_enable_fiq(struct irq_data *d) > +{ > + gic_set_group_irq(d, 0); > +} > + > +static void gic_disable_fiq(struct irq_data *d) > +{ > + gic_set_group_irq(d, 1); > +}
I think both the above functions should also call gic_unmask_irq() and gic_mask_irq() directly rather than looping through enable_irq()/ disable_irq().
-- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net.
|