lkml.org 
[lkml]   [2014]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] scsi: qla2xxx: qla_mr.c: Cleaning up missing null-terminate in conjunction with strncpy
Date
Replacing strncpy with strlcpy to avoid strings that lacks null terminate.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/scsi/qla2xxx/qla_mr.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c
index 4775baa..23bc7e2 100644
--- a/drivers/scsi/qla2xxx/qla_mr.c
+++ b/drivers/scsi/qla2xxx/qla_mr.c
@@ -1868,21 +1868,21 @@ qlafx00_fx_disc(scsi_qla_host_t *vha, fc_port_t *fcport, uint16_t fx_type)
phost_info = &preg_hsi->hsi;
memset(preg_hsi, 0, sizeof(struct register_host_info));
phost_info->os_type = OS_TYPE_LINUX;
- strncpy(phost_info->sysname,
+ strlcpy(phost_info->sysname,
p_sysid->sysname, SYSNAME_LENGTH);
- strncpy(phost_info->nodename,
+ strlcpy(phost_info->nodename,
p_sysid->nodename, NODENAME_LENGTH);
if (!strcmp(phost_info->nodename, "(none)"))
ha->mr.host_info_resend = true;
- strncpy(phost_info->release,
+ strlcpy(phost_info->release,
p_sysid->release, RELEASE_LENGTH);
- strncpy(phost_info->version,
+ strlcpy(phost_info->version,
p_sysid->version, VERSION_LENGTH);
- strncpy(phost_info->machine,
+ strlcpy(phost_info->machine,
p_sysid->machine, MACHINE_LENGTH);
- strncpy(phost_info->domainname,
+ strlcpy(phost_info->domainname,
p_sysid->domainname, DOMNAME_LENGTH);
- strncpy(phost_info->hostdriver,
+ strlcpy(phost_info->hostdriver,
QLA2XXX_VERSION, VERSION_LENGTH);
do_gettimeofday(&tv);
preg_hsi->utc = (uint64_t)tv.tv_sec;
--
1.7.10.4


\
 
 \ /
  Last update: 2014-09-15 00:21    [W:0.096 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site