Messages in this thread | | | From | Bjorn Helgaas <> | Date | Fri, 12 Sep 2014 15:35:10 -0600 | Subject | Re: [PATCH v1 02/13] PCI: Move pci_configure_slot() to drivers/pci/probe.c |
| |
On Fri, Sep 12, 2014 at 3:31 PM, Yinghai Lu <yinghai@kernel.org> wrote: > On Fri, Sep 12, 2014 at 11:03 AM, Bjorn Helgaas <bhelgaas@google.com> wrote: >> Move pci_configure_slot() and related functions from >> drivers/pci/hotplug/pcihp_slot to drivers/pci/probe.c. >> >> This is to prepare for doing device configuration during the normal >> enumeration process instead of just after hot-add. >> >> ...
> Would be better if those acpi related code could be moved to > drivers/pci/pci-acpi.c. and should put pci_configure_device() from > next patch to pci-acpi.c.
Good point. I just moved a bunch of the stuff from drivers/pci/hotplug/acpi_pcihp.c to pci-acpi.h, because acpi_pcihp.c is not compiled unless CONFIG_PCI_HOTPLUG is set. And this stuff probably should go there, too.
> Other that, for the whole patchset, > > Acked-by: Yinghai Lu <yinghai@kernel.org>
| |