Messages in this thread Patch in this message | | | Subject | [PATCH v1 06/13] PCI: shpchp: Remove pci_configure_slot() usage | From | Bjorn Helgaas <> | Date | Fri, 12 Sep 2014 12:03:28 -0600 |
| |
We now configure each PCI device as it is enumerated, in pci_device_add(), so remove the configuration done in shpchp.
That configuration, in pci_configure_device(), does not include the MPS/MRRS configuration done by pcie_bus_configure_settings(), so keep that here.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> --- drivers/pci/hotplug/shpchp_pci.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/pci/hotplug/shpchp_pci.c b/drivers/pci/hotplug/shpchp_pci.c index 469454e0cc48..f8cd3a27e351 100644 --- a/drivers/pci/hotplug/shpchp_pci.c +++ b/drivers/pci/hotplug/shpchp_pci.c @@ -69,13 +69,7 @@ int shpchp_configure_device(struct slot *p_slot) } pci_assign_unassigned_bridge_resources(bridge); - - list_for_each_entry(dev, &parent->devices, bus_list) { - if (PCI_SLOT(dev->devfn) != p_slot->device) - continue; - pci_configure_slot(dev); - } - + pcie_bus_configure_settings(parent); pci_bus_add_devices(parent); out:
| |