Messages in this thread Patch in this message | | | From | Bartlomiej Zolnierkiewicz <> | Subject | [PATCH] mfd: sec-core: add missing sec_irq_init() return value checking | Date | Thu, 07 Aug 2014 18:44:18 +0200 |
| |
sec_irq_init() can fail if it encounters unknown device type or on regmap_add_irq_chip() error. Add missing sec_irq_init() return value checking to sec_pmic_probe().
Tested on Insignal's Exynos4412 based Origen board.
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> Cc: Sangbeom Kim <sbkim73@samsung.com> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> --- patch is against next-20140804 branch of linux-next kernel
drivers/mfd/sec-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c index dba7e2b..f498867 100644 --- a/drivers/mfd/sec-core.c +++ b/drivers/mfd/sec-core.c @@ -353,7 +353,9 @@ static int sec_pmic_probe(struct i2c_client *i2c, if (pdata && pdata->cfg_pmic_irq) pdata->cfg_pmic_irq(); - sec_irq_init(sec_pmic); + ret = sec_irq_init(sec_pmic); + if (ret) + return ret; pm_runtime_set_active(sec_pmic->dev); -- 1.8.2.3
| |