Messages in this thread | | | From | Arnaldo Carvalho de Melo <> | Subject | [RFC 00/10] perf pollfd series | Date | Fri, 22 Aug 2014 17:59:40 -0300 |
| |
Hi,
This is an alternative series to the one Jiri Olsa posted to use the fixes he made to the kernel side to allow tooling to notice that a thread had exited by looking at the pollfd.revents looking for POLLHUP notifications.
Once all event file descriptors are removed from the evlist pollfd array, tools can make a decision about exiting or telling the user about what happened, asking to guidance on what to do next.
The main difference in this approach is that a new class, which Jiri called 'poller' and I called 'fdarray', grew up from what was in evlist->pollfd and associated operations, while Jiri first introduced a new class and then made tooling use it.
The details of the implementation should be clear on the changelog comments, please let me know if you see any problems, and if I can have your acked-by/tested-by/whatever-else tags to get this moving forward.
Ah, there is still one missing thing which is to make the hists browser in live mode be notified that all monitored events are POLLHUP'ed, will get to that in followup patches.
The kernel bits were sent together with my latest pull req to Ingo, this series is on top of that branch and is available at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/pollfd
- Arnaldo
Arnaldo Carvalho de Melo (10): perf evlist: Introduce perf_evlist__filter_pollfd method perf tests: Add test for perf_evlist__filter_pollfd() perf evlist: Monitor POLLERR and POLLHUP events too perf record: Filter out POLLHUP'ed file descriptors perf trace: Filter out POLLHUP'ed file descriptors perf evlist: Allow growing pollfd on add method perf tests: Add pollfd growing test perf kvm stat live: Use perf_evlist__add_pollfd() instead of local equivalent perf evlist: Introduce poll method for common code idiom tools lib api: Adopt fdarray class from perf's evlist
| |