lkml.org 
[lkml]   [2014]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCHSET 0/2] perf hists browser: Cleanup callchain routines (v2)
Date
Hello,

This patch fixes and cleans up TUI callchain routines. I tried to
consolidate similar functions but not to break the current output with
this change. Hope that it makes code more readable and maintainable.

It should not change any behavior and outputs. I verified it with
expanding by 'E' key + dumping by 'P' key on TUI and then running
"diff -u" results before and after the patchset.

Actually I have more changes that would change (or improve) some
behavior and output. I'll post them after this patchset is merged.


* changes in v2)
- drop patch 1-3 in v1 since it's already merged
- update description (Arnaldo)
- remove stylish changes (Arnaldo)
- remove unnecessary 'has_single_node' check


You can get this from 'perf/callchain-fix-v2' branch on my tree:

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Any comments are welcome, thanks
Namhyung


Namhyung Kim (2):
perf hists browser: Cleanup callchain print functions
perf hists browser: Consolidate callchain print functions in TUI

tools/perf/ui/browsers/hists.c | 302 +++++++++++++----------------------------
1 file changed, 95 insertions(+), 207 deletions(-)

--
2.0.0



\
 
 \ /
  Last update: 2014-08-21 03:21    [W:0.630 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site