Messages in this thread Patch in this message | | | From | jgross@suse ... | Subject | [PATCH] Save command pool address of Scsi_Host | Date | Fri, 1 Aug 2014 08:27:05 +0200 |
| |
From: Juergen Gross <jgross@suse.com>
If a scsi host driver specifies .cmd_len in it's scsi_host_template, a driver's private command pool is needed. scsi_find_host_cmd_pool() will locate it, but scsi_alloc_host_cmd_pool() isn't saving the pool address in the host template.
This will result in an access error when the host is removed.
Avoid the problem by saving the address of a new allocated command pool where it is expected.
Signed-off-by: Juergen Gross <jgross@suse.com> --- drivers/scsi/scsi.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 88d46fe..da769f9 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c @@ -380,6 +380,10 @@ scsi_alloc_host_cmd_pool(struct Scsi_Host *shost) pool->slab_flags |= SLAB_CACHE_DMA; pool->gfp_mask = __GFP_DMA; } + + if (shost->hostt->cmd_size) + shost->hostt->cmd_pool = pool; + return pool; } -- 1.8.4.5
| |