Messages in this thread | | | Date | Wed, 9 Jul 2014 18:38:22 +0530 | From | Amit Shah <> | Subject | Re: [PATCH v2 1/2] hwrng: fetch randomness only after device init |
| |
On (Wed) 09 Jul 2014 [07:53:17], Jason Cooper wrote: > On Sat, Jul 05, 2014 at 11:04:52AM +0530, Amit Shah wrote: > > Commit d9e7972619334 "hwrng: add randomness to system from rng sources" > > added a call to rng_get_data() from the hwrng_register() function. > > However, some rng devices need initialization before data can be read > > from them. > > > > This commit makes the call to rng_get_data() depend on no init fn > > pointer being registered by the device. If an init function is > > registered, this call is made after device init. > > > > CC: Kees Cook <keescook@chromium.org> > > CC: Jason Cooper <jason@lakedaemon.net> > > CC: Herbert Xu <herbert@gondor.apana.org.au> > > CC: <stable@vger.kernel.org> # For v3.15+ > > Signed-off-by: Amit Shah <amit.shah@redhat.com> > > --- > > drivers/char/hw_random/core.c | 31 +++++++++++++++++++++++++------ > > 1 file changed, 25 insertions(+), 6 deletions(-) > > Thanks for cleaning this up!
Thanks!
Any thoughts on the follow-up patch posted later that resolves some of the weirdness in init?
Amit
| |