Messages in this thread | | | Date | Mon, 7 Jul 2014 11:21:07 +0530 | From | Amit Shah <> | Subject | Re: [PATCH v2 2/2] virtio: rng: ensure reads happen after successful probe |
| |
On (Sun) 06 Jul 2014 [21:38:36], Kees Cook wrote: > On Fri, Jul 4, 2014 at 10:34 PM, Amit Shah <amit.shah@redhat.com> wrote: > > The hwrng core asks for random data in the hwrng_register() call itself > > from commit d9e7972619. This doesn't play well with virtio -- the > > DRIVER_OK bit is only set by virtio core on a successful probe, and > > we're not yet out of our probe routine when this call is made. This > > causes the host to not acknowledge any requests we put in the virtqueue, > > and the insmod or kernel boot process just waits for data to arrive from > > the host, which never happens. > > Doesn't this mean that virtio-rng won't ever contribute entropy to the system?
The initial randomness? Yes. But it'll start contributing entropy as soon as it's used as the current source.
Is this a huge negative?
Amit
| |