Messages in this thread Patch in this message | | | Date | Sun, 27 Jul 2014 12:36:51 +0530 | From | Himangi Saraogi <> | Subject | [PATCH] net/ipv4: Use IS_ERR_OR_NULL |
| |
This patch introduces the use of the macro IS_ERR_OR_NULL in place of tests for NULL and IS_ERR.
The following Coccinelle semantic patch was used for making the change:
@@ expression e; @@
- e == NULL || IS_ERR(e) + IS_ERR_OR_NULL(e) || ...
Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> --- net/ipv4/gre_offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/gre_offload.c b/net/ipv4/gre_offload.c index f0bdd47..6556263 100644 --- a/net/ipv4/gre_offload.c +++ b/net/ipv4/gre_offload.c @@ -74,7 +74,7 @@ static struct sk_buff *gre_gso_segment(struct sk_buff *skb, /* segment inner packet. */ enc_features = skb->dev->hw_enc_features & netif_skb_features(skb); segs = skb_mac_gso_segment(skb, enc_features); - if (!segs || IS_ERR(segs)) { + if (IS_ERR_OR_NULL(segs)) { skb_gso_error_unwind(skb, protocol, ghl, mac_offset, mac_len); goto out; } -- 1.9.1
| |