Messages in this thread | | | Date | Wed, 2 Jul 2014 20:44:02 +0100 | From | Mark Brown <> | Subject | Re: question about drivers/spi/spi-au1550.c |
| |
On Thu, Jul 03, 2014 at 12:31:45AM +0530, Himangi Saraogi wrote:
> I find in the probe function that hw->ioarea is allocated using > request_mem_region but a release_resource and kfree is called on it instead > of a release_mem_region. Is there any special concern behind this. I was > planning to use devm_ioremap_resource here.
I'd expect this is just a bug you've spotted. If you could send two patches, one fixing the bug and the other doing the devm_ conversion, that'd be ideal but a single patch is also fine. [unhandled content-type:application/pgp-signature] | |