Messages in this thread Patch in this message | | | From | Rasmus Villemoes <> | Subject | [PATCH] drivers: tty: Remove redundant memset() in initialize_tty_struct | Date | Thu, 10 Jul 2014 18:16:24 +0200 |
| |
All callers (all two) of initialize_tty_struct() have just obtained the passed tty_struct from alloc_tty_struct(), which uses kzalloc(). So there is no reason to clear the memory again.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> --- drivers/tty/tty_io.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 3411071..8199a4e 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -3015,7 +3015,6 @@ static struct device *tty_get_device(struct tty_struct *tty) void initialize_tty_struct(struct tty_struct *tty, struct tty_driver *driver, int idx) { - memset(tty, 0, sizeof(struct tty_struct)); kref_init(&tty->kref); tty->magic = TTY_MAGIC; tty_ldisc_init(tty); -- 1.9.2
| |