Messages in this thread Patch in this message | | | From | Viresh Kumar <> | Subject | [PATCH] cpufreq: tegra: update comment for clarity | Date | Fri, 6 Jun 2014 10:08:58 +0530 |
| |
Tegra's driver got updated a bit (00917dd cpufreq: Tegra: implement intermediate frequency callbacks) and implements new 'intermediate freq' infrastructure of core. Above commit updated comments about when to call clk_prepare_enable(pll_x_clk) and Doug wasn't satisfied with those comments and said this:
> The "Though when target-freq is intermediate freq, we don't need to > take this reference." makes me think that this function is actually > called when target-freq is intermediate freq. I don't think it is, > right?
For better clarity just make that comment more explicit about when we call tegra_target_intermediate(). Wasn't sure if we actually need a commit for this, but anyway lets other decide if its worth enough :)
Reported-by: Doug Anderson <dianders@chromium.org> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/tegra-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/tegra-cpufreq.c b/drivers/cpufreq/tegra-cpufreq.c index a5fbc0a..48bc89b 100644 --- a/drivers/cpufreq/tegra-cpufreq.c +++ b/drivers/cpufreq/tegra-cpufreq.c @@ -73,7 +73,7 @@ static int tegra_target_intermediate(struct cpufreq_policy *policy, * off when we move the cpu off of it as enabling it again while we * switch to it from tegra_target() would take additional time. Though * when target-freq is intermediate freq, we don't need to take this - * reference. + * reference and so this routine isn't called at all. */ clk_prepare_enable(pll_x_clk); -- 2.0.0.rc2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |