Messages in this thread Patch in this message | | | From | Nicholas Krause <> | Subject | [PATCH v2] hid-appleir: Fix kernel panic due to null pointer | Date | Mon, 30 Jun 2014 22:14:25 -0400 |
| |
Fixes a null pointer in appleir_input_configured due to reading into wrong size array. Changed the variable to input_dev->keycodemax.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com> --- drivers/hid/hid-appleir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-appleir.c b/drivers/hid/hid-appleir.c index 0e6a42d..cc02df4 100644 --- a/drivers/hid/hid-appleir.c +++ b/drivers/hid/hid-appleir.c @@ -272,7 +272,7 @@ static void appleir_input_configured(struct hid_device *hid, input_dev->evbit[0] = BIT(EV_KEY) | BIT(EV_REP); memcpy(appleir->keymap, appleir_key_table, sizeof(appleir->keymap)); - for (i = 0; i < ARRAY_SIZE(appleir_key_table); i++) + for (i = 0; i < appleir->keymap; i++) set_bit(appleir->keymap[i], input_dev->keybit); clear_bit(KEY_RESERVED, input_dev->keybit); } -- 1.9.1
| |