lkml.org 
[lkml]   [2014]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: ioapic: Fix irq_free_descs count
On Mon, 30 Jun 2014, Keith Busch wrote:

> Signed-off-by: Keith Busch <keith.busch@intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: x86@kernel.org

Acked-by: David Rientjes <rientjes@google.com>

This is definitely a fix for "genirq: Provide generic hwirq allocation
facility", but the changelog doesn't describe what the problem is and the
title that this somehow fixes irq_free_descs() doesn't make any sense.

It's the equivalent of just doing

- irq_free_descs(from, cnt);
+ irq_free_descs(from, i - from);

I'd suggest the patch title be changed to

genirq: Fix memory leak when calling irq_free_hwirqs()

and the changelog state

irq_free_hwirqs() always calls irq_free_descs() with a cnt == 0 which
makes it a no-op since the interrupt count to free is decremented in
itself.


\
 
 \ /
  Last update: 2014-07-01 03:21    [W:0.300 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site