Messages in this thread | | | Date | Mon, 30 Jun 2014 16:15:01 -0600 (MDT) | From | Keith Busch <> | Subject | Re: [PATCH] x86: ioapic: Fix irq_free_descs count |
| |
On Mon, 30 Jun 2014, David Rientjes wrote: > On Mon, 30 Jun 2014, Keith Busch wrote: > >> Signed-off-by: Keith Busch <keith.busch@intel.com> >> Cc: Thomas Gleixner <tglx@linutronix.de> >> Cc: x86@kernel.org > > Acked-by: David Rientjes <rientjes@google.com> > > This is definitely a fix for "genirq: Provide generic hwirq allocation > facility", but the changelog doesn't describe what the problem is and the > title that this somehow fixes irq_free_descs() doesn't make any sense.
My mistake, I used the component from the commit I bisected the bug down to.
> It's the equivalent of just doing > > - irq_free_descs(from, cnt); > + irq_free_descs(from, i - from); > > I'd suggest the patch title be changed to > > genirq: Fix memory leak when calling irq_free_hwirqs() > > and the changelog state > > irq_free_hwirqs() always calls irq_free_descs() with a cnt == 0 which > makes it a no-op since the interrupt count to free is decremented in > itself.
Yes, I like your suggestion. Should I submit a v2, or will maintainer replace the changelog?
| |