Messages in this thread | | | Date | Tue, 03 Jun 2014 19:50:47 -0600 | From | David Ahern <> | Subject | Re: [PATCH 05/32] perf kbuild: fix recursive invocation of config/features-checks |
| |
you are missing a commit message as to why the below change is needed. What happens without this patch. What happens with this patch.
David
On 6/3/14, 4:05 PM, Alexis Berlemont wrote: > --- > tools/perf/Makefile.kbuild | 2 +- > tools/perf/config/Makefile | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/Makefile.kbuild b/tools/perf/Makefile.kbuild > index 1e3621f..b2d0d08 100644 > --- a/tools/perf/Makefile.kbuild > +++ b/tools/perf/Makefile.kbuild > @@ -90,7 +90,7 @@ VPATH += $(src-perf) > > export src-perf obj-perf > > -OUTPUT := $(obj-perf) > +OUTPUT := $(obj-perf)/ > > export OUTPUT > > diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile > index 78ee62d..1760f57 100644 > --- a/tools/perf/config/Makefile > +++ b/tools/perf/config/Makefile > @@ -135,7 +135,7 @@ endif > > feature_check = $(eval $(feature_check_code)) > define feature_check_code > - feature-$(1) := $(shell $(MAKE) OUTPUT=$(OUTPUT_FEATURES) CFLAGS="$(EXTRA_CFLAGS) $(FEATURE_CHECK_CFLAGS-$(1))" LDFLAGS="$(LDFLAGS) $(FEATURE_CHECK_LDFLAGS-$(1))" -C config/feature-checks test-$1.bin >/dev/null 2>/dev/null && echo 1 || echo 0) > + feature-$(1) := $(shell $(MAKE) OUTPUT=$(OUTPUT_FEATURES) CFLAGS="$(EXTRA_CFLAGS) $(FEATURE_CHECK_CFLAGS-$(1))" LDFLAGS="$(LDFLAGS) $(FEATURE_CHECK_LDFLAGS-$(1))" -C $(src-perf)/config/feature-checks test-$1.bin >/dev/null 2>/dev/null && echo 1 || echo 0) > endef > > feature_set = $(eval $(feature_set_code)) > @@ -234,7 +234,7 @@ ifeq ($(feature-all), 1) > # > $(foreach feat,$(CORE_FEATURE_TESTS),$(call feature_set,$(feat))) > else > - $(shell $(MAKE) OUTPUT=$(OUTPUT_FEATURES) CFLAGS="$(EXTRA_CFLAGS)" LDFLAGS=$(LDFLAGS) -i -j -C config/feature-checks $(addsuffix .bin,$(CORE_FEATURE_TESTS)) >/dev/null 2>&1) > + $(shell $(MAKE) OUTPUT=$(OUTPUT_FEATURES) CFLAGS="$(EXTRA_CFLAGS)" LDFLAGS=$(LDFLAGS) -i -j -C $(src-perf)/config/feature-checks $(addsuffix .bin,$(CORE_FEATURE_TESTS)) >/dev/null 2>&1) > $(foreach feat,$(CORE_FEATURE_TESTS),$(call feature_check,$(feat))) > endif > >
| |