lkml.org 
[lkml]   [2014]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/32] perf kbuild: remove useless #ifdef directives
missing commit message as to why the ifdef directives useless.

if I build perf after applying this patch and I don't have devel code
for tui and gui will it still build?

David

On 6/3/14, 4:06 PM, Alexis Berlemont wrote:
> ---
> tools/perf/ui/setup.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/tools/perf/ui/setup.c b/tools/perf/ui/setup.c
> index 66ecd08..cb69740 100644
> --- a/tools/perf/ui/setup.c
> +++ b/tools/perf/ui/setup.c
> @@ -71,20 +71,16 @@ void setup_browser(bool fallback_to_pager)
>
> switch (use_browser) {
> case 2:
> -#if defined(CONFIG_GUI) || !defined(CONFIG_KBUILD)
> if (setup_gtk_browser() == 0)
> break;
> printf("GTK browser requested but could not find %s\n",
> PERF_GTK_DSO);
> sleep(1);
> -#endif
> /* fall through */
> -#if defined(CONFIG_TUI) || !defined(CONFIG_KBUILD)
> case 1:
> use_browser = 1;
> if (ui__init() == 0)
> break;
> -#endif
> /* fall through */
> default:
> use_browser = 0;
> @@ -100,16 +96,12 @@ void exit_browser(bool wait_for_ok __maybe_unused)
> {
> switch (use_browser) {
> case 2:
> -#if defined(CONFIG_GUI) || !defined(CONFIG_KBUILD)
> exit_gtk_browser(wait_for_ok);
> break;
> -#endif
>
> -#if defined(CONFIG_TUI) || !defined(CONFIG_KBUILD)
> case 1:
> ui__exit(wait_for_ok);
> break;
> -#endif
>
> default:
> break;
>



\
 
 \ /
  Last update: 2014-06-04 04:41    [W:0.227 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site