lkml.org 
[lkml]   [2014]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/4] DRBG: Fix format string for debugging statements
Date
Am Sonntag, 29. Juni 2014, 12:24:02 schrieb Stephen Rothwell:

Hi Stephen,

> Hi Stephan,
>
> On Sat, 28 Jun 2014 22:01:46 +0200 Stephan Mueller <smueller@chronox.de>
wrote:
> > @@ -1987,8 +1987,9 @@ static int __init drbg_init(void)
> >
> > if (ARRAY_SIZE(drbg_cores) * 2 > ARRAY_SIZE(drbg_algs)) {
> >
> > pr_info("DRBG: Cannot register all DRBG types"
> >
> > - "(slots needed: %lu, slots available: %lu)\n",
> > - ARRAY_SIZE(drbg_cores) * 2, ARRAY_SIZE(drbg_algs));
> > + "(slots needed: %u, slots available: %u)\n",
> > + (unsigned int)ARRAY_SIZE(drbg_cores) * 2,
> > + (unsigned int)ARRAY_SIZE(drbg_algs));
>
> Doesn't ARRAY_SIZE() always return a size_t? In which case surely we
> need no casts, but need to us %zu in the format string.

Unfortunately not at all. On my x86_64, I get the compiler warning that
ARRAY_SIZE is a long unsigned int without the cast.

Ciao
Stephan
--
| Cui bono? |


\
 
 \ /
  Last update: 2014-06-29 06:01    [W:0.108 / U:1.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site