lkml.org 
[lkml]   [2014]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] DRBG: Fix format string for debugging statements
Hi Stephan,

On Sat, 28 Jun 2014 22:01:46 +0200 Stephan Mueller <smueller@chronox.de> wrote:
>
> @@ -1987,8 +1987,9 @@ static int __init drbg_init(void)
>
> if (ARRAY_SIZE(drbg_cores) * 2 > ARRAY_SIZE(drbg_algs)) {
> pr_info("DRBG: Cannot register all DRBG types"
> - "(slots needed: %lu, slots available: %lu)\n",
> - ARRAY_SIZE(drbg_cores) * 2, ARRAY_SIZE(drbg_algs));
> + "(slots needed: %u, slots available: %u)\n",
> + (unsigned int)ARRAY_SIZE(drbg_cores) * 2,
> + (unsigned int)ARRAY_SIZE(drbg_algs));

Doesn't ARRAY_SIZE() always return a size_t? In which case surely we
need no casts, but need to us %zu in the format string.

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au


\
 
 \ /
  Last update: 2014-06-29 05:01    [W:0.316 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site