Messages in this thread | | | Date | Sun, 29 Jun 2014 12:24:02 +1000 | From | Stephen Rothwell <> | Subject | Re: [PATCH 3/4] DRBG: Fix format string for debugging statements |
| |
Hi Stephan,
On Sat, 28 Jun 2014 22:01:46 +0200 Stephan Mueller <smueller@chronox.de> wrote: > > @@ -1987,8 +1987,9 @@ static int __init drbg_init(void) > > if (ARRAY_SIZE(drbg_cores) * 2 > ARRAY_SIZE(drbg_algs)) { > pr_info("DRBG: Cannot register all DRBG types" > - "(slots needed: %lu, slots available: %lu)\n", > - ARRAY_SIZE(drbg_cores) * 2, ARRAY_SIZE(drbg_algs)); > + "(slots needed: %u, slots available: %u)\n", > + (unsigned int)ARRAY_SIZE(drbg_cores) * 2, > + (unsigned int)ARRAY_SIZE(drbg_algs));
Doesn't ARRAY_SIZE() always return a size_t? In which case surely we need no casts, but need to us %zu in the format string.
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au
| |