Messages in this thread | | | Date | Mon, 2 Jun 2014 14:14:45 +0100 | From | John Church <> | Subject | Re: [PATCH] staging: lustre: fix sparse warnings for undeclared symbols |
| |
On Mon, Jun 02, 2014 at 03:19:18PM +0300, Dan Carpenter wrote: > > Why not just make them static? They don't seem to be used outside of > that file. What am I missing? >
Given a 50/50 choice I based my decision on the surrounding functions which were mostly defined in the header file.
I should have done a little more invstigation which would have led me to the opposite conclusion.
I will redo them as static and resumbit.
Thanks for your help Dan.
Regards, John
| |