Messages in this thread | | | Date | Mon, 2 Jun 2014 15:19:18 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: lustre: fix sparse warnings for undeclared symbols |
| |
On Mon, Jun 02, 2014 at 01:03:48PM +0100, John Church wrote: > This patch fixes the following sparse warnings for drivers/staging/lustre/lnet/lnet/router.c: > > router.c:139:1: warning: symbol 'lnet_ni_notify_locked' was not declared. Should it be static? > router.c:277:1: warning: symbol 'lnet_add_route_to_rnet' was not declared. Should it be static? >
Why not just make them static? They don't seem to be used outside of that file. What am I missing?
regards, dan carpenter
| |