lkml.org 
[lkml]   [2014]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] IO: hid-sensor-magn-3d: Add in support for True/Magnetic North HID usages
On 05/28/2014 02:15 PM, Reyad Attiyat wrote:
>> +static void sensor_hub_fill_attr_info(
>> + struct hid_sensor_hub_attribute_info *info,
>> + s32 index, s32 report_id, struct hid_field *field)
>> +{
>> + info->index = index;
>> + info->report_id = report_id;
>> + info->units = field->unit;
>> + info->unit_expo = field->unit_exponent;
>> + info->size = (field->report_size * field->report_count)/8;
>> + info->logical_minimum = field->logical_minimum;
>> + info->logical_maximum = field->logical_maximum;
>> }
> I copied this function from hid/hid-sensor-hub.c as it is marked
> static in that file. I use it to fill attributes as I find them.
> Should I create an another patch to make it non-static?

I didn't check your implementation. But
sensor_hub_input_get_attribute_info()
function is not enough? We are already using to get other attributes for
x, y and Z.

Thanks,
Srinivas


>> + list_for_each_entry(report, &report_enum->report_list, list) {
>> + for (i = 0; i < report->maxfield; ++i) {
>> + field = report->field[i];
>> +
>> + for (j = 0; j < field->maxusage; j++) {
>> + usage = &(field->usage[j]);
>> +
> This is how I mange to find all possible hid reports in the parse
> reports function. I noticed that in the other function that was used,
> sensor_hub_input_get_attribute_info(), it only uses field->usage[0].
> Is there a reason for this and should I change my current
> implementation?
>



\
 
 \ /
  Last update: 2014-05-29 01:01    [W:0.072 / U:1.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site