Messages in this thread Patch in this message | | | From | Djordje Zekovic <> | Subject | [PATCH] staging: usbip: use kcalloc instead of kzalloc for array allocations | Date | Fri, 23 May 2014 10:17:38 +0000 |
| |
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read.
Signed-off-by: Djordje Zekovic <dj@zeko.me> --- drivers/staging/usbip/stub_tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/stub_tx.c b/drivers/staging/usbip/stub_tx.c index 1622563..4994090 100644 --- a/drivers/staging/usbip/stub_tx.c +++ b/drivers/staging/usbip/stub_tx.c @@ -179,7 +179,7 @@ static int stub_send_ret_submit(struct stub_device *sdev) else iovnum = 2; - iov = kzalloc(iovnum * sizeof(struct kvec), GFP_KERNEL); + iov = kcalloc(iovnum * sizeof(struct kvec), GFP_KERNEL); if (!iov) { usbip_event_add(&sdev->ud, SDEV_EVENT_ERROR_MALLOC); -- 1.8.5.2
| |