Messages in this thread | | | Date | Wed, 9 Apr 2014 15:42:42 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 1/2] perf, tools, stat: Initialize statistics correctly |
| |
On Tue, Mar 25, 2014 at 10:31:38AM -0700, Andi Kleen wrote: > From: Andi Kleen <ak@linux.intel.com> > > perf stat did initialize the stats structure used to compute > stddev etc. incorrectly. It merely zeroes it. But one member > (min) needs to be set to a non zero value. This causes min > to be not computed at all. Call init_stats() correctly. > > It doesn't matter for stat currently because it doesn't use > min, but it's still better to do it correctly. > > The other users of statistics are already correct. > > Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks, jirka
| |