Messages in this thread | | | Date | Mon, 14 Apr 2014 19:09:32 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH 2/2] perf, tools: Support spark lines in perf stat |
| |
> fput could go into print_stat_spark
I wanted to keep the function generic, so that it can be easily used in other places. Adding the space is somewhat specific to stat.
Also the rest of the stat code has the white space printing centralized in the caller too. I suppose makes it easier to change.
> > + len = n; > > + if (len > NUM_SPARK_VALS) > > + len = NUM_SPARK_VALS; > > + if (all_the_same(stat->svals, len)) > > + return; > > + print_spark(f, stat->svals, len); > > + if (stat->n > NUM_SPARK_VALS) > > + fputs("..", f); > > +} > > whats the reason for 'n' in here? looks like you could do only with 'len'
len is capped to NUM_SPARK_VALS, but the test needs to be on the uncapped value. Otherwise exactly NUM_SPARK_VALS entries would get a .. incorrectly.
-Andi
| |