| Subject | Re: [PATCH v2 01/24] input: Add ff-memless-next module | From | Oliver Neukum <> | Date | Wed, 23 Apr 2014 14:12:59 +0200 |
| |
On Tue, 2014-04-22 at 15:59 +0200, Michal Malý wrote: > +/* Some devices might have a limit on how many uncombinable effects > + * can be played at once */ > +static int mlnx_upload_conditional(struct mlnx_device *mlnxdev, > + const struct ff_effect *effect) > +{ > + struct mlnx_effect_command ecmd = { > + .cmd = MLNX_UPLOAD_UNCOMB, > + .u.uncomb.id = effect->id, > + .u.uncomb.effect = effect > + }; > + return mlnxdev->control_effect(mlnxdev->dev, mlnxdev->private, > &ecmd); > +} > +
This mean you are building the structure on the stack
1. Are you sure nobody retains a reference? 2. That is needlessly inefficient
Regards Oliver
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|