Messages in this thread | | | From | Andy Lutomirski <> | Date | Sat, 29 Mar 2014 23:49:34 -0700 | Subject | Re: [PATCH] x86: Fix the symbol versions on the 32-bit vDSO |
| |
On Sat, Mar 29, 2014 at 11:33 PM, Stefani Seibold <stefani@seibold.net> wrote: > Am Samstag, den 29.03.2014, 13:15 -0700 schrieb Andy Lutomirski: >> The new symbols provide the same API as the 64-bit variants, so they >> should have the same symbol version name. This can't break >> userspace, since these symbols are new for 32-bit Linux. >> > > This breaks my glibc patch... What is the benefit for doing this in that > way?
The functions do the same thing as they do in the 64-bit and x32 cases, so the versions should be the same.
> >> Signed-off-by: Andy Lutomirski <luto@amacapital.net> >> --- >> arch/x86/vdso/vdso32/vdso32.lds.S | 10 +++++++--- >> 1 file changed, 7 insertions(+), 3 deletions(-) >> >> diff --git a/arch/x86/vdso/vdso32/vdso32.lds.S b/arch/x86/vdso/vdso32/vdso32.lds.S >> index 28c4607..aadb8b9 100644 >> --- a/arch/x86/vdso/vdso32/vdso32.lds.S >> +++ b/arch/x86/vdso/vdso32/vdso32.lds.S >> @@ -23,14 +23,18 @@ ENTRY(__kernel_vsyscall); >> */ >> VERSION >> { >> + LINUX_2.6 { >> + global: >> + __vdso_clock_gettime; >> + __vdso_gettimeofday; >> + __vdso_time; >> + }; >> + >> LINUX_2.5 { >> global: >> __kernel_vsyscall; >> __kernel_sigreturn; >> __kernel_rt_sigreturn; >> - __vdso_clock_gettime; >> - __vdso_gettimeofday; >> - __vdso_time; >> local: *; >> }; >> } > >
-- Andy Lutomirski AMA Capital Management, LLC
| |