Messages in this thread | | | Subject | Re: [PATCH] x86: Fix the symbol versions on the 32-bit vDSO | From | "H. Peter Anvin" <> | Date | Sun, 30 Mar 2014 09:59:17 -0700 |
| |
Has your glibc patch been accepted upstream yet? I'm assuming not, in which case this is a legitimate patch.
On March 29, 2014 11:33:37 PM PDT, Stefani Seibold <stefani@seibold.net> wrote: >Am Samstag, den 29.03.2014, 13:15 -0700 schrieb Andy Lutomirski: >> The new symbols provide the same API as the 64-bit variants, so they >> should have the same symbol version name. This can't break >> userspace, since these symbols are new for 32-bit Linux. >> > >This breaks my glibc patch... What is the benefit for doing this in >that >way? > >> Signed-off-by: Andy Lutomirski <luto@amacapital.net> >> --- >> arch/x86/vdso/vdso32/vdso32.lds.S | 10 +++++++--- >> 1 file changed, 7 insertions(+), 3 deletions(-) >> >> diff --git a/arch/x86/vdso/vdso32/vdso32.lds.S >b/arch/x86/vdso/vdso32/vdso32.lds.S >> index 28c4607..aadb8b9 100644 >> --- a/arch/x86/vdso/vdso32/vdso32.lds.S >> +++ b/arch/x86/vdso/vdso32/vdso32.lds.S >> @@ -23,14 +23,18 @@ ENTRY(__kernel_vsyscall); >> */ >> VERSION >> { >> + LINUX_2.6 { >> + global: >> + __vdso_clock_gettime; >> + __vdso_gettimeofday; >> + __vdso_time; >> + }; >> + >> LINUX_2.5 { >> global: >> __kernel_vsyscall; >> __kernel_sigreturn; >> __kernel_rt_sigreturn; >> - __vdso_clock_gettime; >> - __vdso_gettimeofday; >> - __vdso_time; >> local: *; >> }; >> }
-- Sent from my mobile phone. Please pardon brevity and lack of formatting.
| |