Messages in this thread Patch in this message | | | From | "Rafael J. Wysocki" <> | Subject | [PATCH] ACPI / container: Fix error code path in container_device_attach() | Date | Wed, 12 Feb 2014 01:05:24 +0100 |
| |
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
To avoid leaking memory on errors from device_register(), do a put_device() on the device object in question in the error code path of container_device_attach().
Fixes: caa73ea158de (ACPI / hotplug / driver core: Handle containers in a special way) Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> ---
3.14 material.
Thanks!
--- drivers/acpi/container.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Index: linux-pm/drivers/acpi/container.c =================================================================== --- linux-pm.orig/drivers/acpi/container.c +++ linux-pm/drivers/acpi/container.c @@ -82,9 +82,10 @@ static int container_device_attach(struc ACPI_COMPANION_SET(dev, adev); dev->release = acpi_container_release; ret = device_register(dev); - if (ret) + if (ret) { + put_device(dev); return ret; - + } adev->driver_data = dev; return 1; }
| |