Messages in this thread | | | Date | Fri, 14 Nov 2014 11:39:12 -0500 | From | Dave Jones <> | Subject | Re: [PATCH v6 0/7] vfs: Non-blockling buffered fs read (page cache only) |
| |
On Fri, Nov 14, 2014 at 11:32:53AM -0500, Jeff Moyer wrote:
> > Can you write a test (or set of) for fstests that exercises this new > > functionality? I'm not worried about performance, just > > correctness.... > > On the subject of testing, I added support to trinity (attached, > untested). That did raise one question. Do we expect applications to > #include <linux/fs.h> to get the RWF_NONBLOCK definition?
Trinity will at least need an addition to include/compat.h for older headers that won't have the definition. Looks ok otherwise.
Also, I usually sit on stuff like this until the syscall numbers are in Linus tree. This is 3.19 stuff I presume ? istr akpm picked up execveat recently, so if that goes in first, we'll need to respin this anyway..
Dave
| |