Messages in this thread | | | Date | Tue, 7 Oct 2014 12:58:17 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 2/5] regulator: Set ena_gpio_valid in regulator drivers |
| |
On Mon, Oct 06, 2014 at 10:17:12PM +0200, Markus Pargmann wrote: > This patch sets the new field ena_gpio_valid for all drivers which set a > valid ena_gpio.
> config.ena_gpio = arizona->pdata.ldoena; > + config.ena_gpio_valid = true;
This patch just unconditionally sets the flag in all drivers which will break any system which relies on the existing behaviour that we ignore GPIO 0. We can definitely set this flag in any DT only system if we get the GPIO from DT but otherwise doing this defeats the point of having the flag in the first place. [unhandled content-type:application/pgp-signature] | |