lkml.org 
[lkml]   [2014]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v5 12/20] x86: perf: intel_pt: Intel PT PMU driver
Date
Peter Zijlstra <peterz@infradead.org> writes:

>> +/* make negative table index stand for the last table entry */
>> +#define TOPA_ENTRY(t, i) ((i) == -1 ? &(t)->table[(t)->last] : &(t)->table[(i)])
>
> code does not match comment; negative would be: i < 0, not i == -1.

Indeed.

> Something like: ({ if (i < 0) i += t->size; t->table[i]; }), might work,
> of course that goes bang when: i !e [-size,size)

Table indices and sizes are measured in different units. Using -1 to
mean the last is just a small convenience, in the code it would be used
explicitly as TOPA_ENTRY(topa, -1).end = 1, for example.

Regards,
--
Alex


\
 
 \ /
  Last update: 2014-10-24 10:41    [W:0.146 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site