| Date | Wed, 22 Oct 2014 16:27:06 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v5 12/20] x86: perf: intel_pt: Intel PT PMU driver |
| |
On Mon, Oct 13, 2014 at 04:45:40PM +0300, Alexander Shishkin wrote: > + if (test_cpu_cap(&boot_cpu_data, X86_FEATURE_INTEL_PT)) { > + for (i = 0; i < PT_CPUID_LEAVES; i++) > + cpuid_count(20, i, > + &pt_pmu.caps[CR_EAX + i * 4], > + &pt_pmu.caps[CR_EBX + i * 4], > + &pt_pmu.caps[CR_ECX + i * 4], > + &pt_pmu.caps[CR_EDX + i * 4]); > + } else > + return -ENODEV;
Please use {} for every multi-line stmt, even if its a single stmt, also use {} in both branches of a condition, even if only one strictly requires it.
|