Messages in this thread | | | From | "Nicholas A. Bellinger" <> | Subject | [PATCH 0/3] percpu-ida/iscsi-target: Address connection reset starved tag hang | Date | Fri, 10 Jan 2014 03:00:44 +0000 |
| |
From: Nicholas Bellinger <nab@linux-iscsi.org>
Hi folks,
This short series addresses a bug in >= v3.12 iscsi-target code where a connection reset occuring once percpu_ida_alloc() goes into starved tag uninterruptible sleep mode causes an indefinate hang, due to the SIGINT being ignored that normally forces the sleeping rx thread into connection cleanup state.
This includes modifying existing percpu_ida_alloc() to allow an state to be passed so that TASK_INTERRUPTIBLE may be optionally set to address this particular case with iscsi-target, and also includes a simple backwards compatibility wrapper for existing consumers.
It also bumps the number of pre-allocated tags by double the allowed per session CmdSN queue_depth in order to avoid the percpu_ida_alloc() straved tags slow path during normal ExpStatSN acknowledgement if at all possible.
Thank you,
--nab
Kent Overstreet (1): percpu_ida: Add tag alloc interface for interruptible sleep
Nicholas Bellinger (2): iscsi-target: Fix connection reset hang with percpu_ida_alloc iscsi-target: Pre-allocate more tags to avoid ack starvation
drivers/target/iscsi/iscsi_target_nego.c | 2 +- drivers/target/iscsi/iscsi_target_util.c | 8 ++++++-- include/linux/percpu_ida.h | 11 ++++++++++- lib/percpu_ida.c | 13 +++++++++---- 4 files changed, 26 insertions(+), 8 deletions(-)
-- 1.7.10.4
| |