Messages in this thread | | | Date | Thu, 9 Jan 2014 08:55:41 -0800 | From | Brian Norris <> | Subject | Re: [PATCH 1/7] mtd: denali: Drop print of build date/time |
| |
On Thu, Dec 26, 2013 at 05:24:53PM +0900, Jingoo Han wrote: > On Tuesday, December 24, 2013 6:55 AM, Josh Triplett wrote: > > > > The kernel already has this information, and individual drivers > > shouldn't duplicate that.
BTW, it is possible for modules to be built at a different time than the kernel, and this code could show that. But it's not very useful anyway, so I agree.
> > This also eliminates the use of __DATE__ and > > __TIME__, which make the build non-deterministic. > > > > Signed-off-by: Josh Triplett <josh@joshtriplett.org> > > (+cc Dinh Nguyen) > > It looks good. :-) > Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Thanks. Pushed to l2-mtd.git.
Brian
| |