lkml.org 
[lkml]   [2013]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/7] mtd: denali: Drop print of build date/time
Date
On Tuesday, December 24, 2013 6:55 AM, Josh Triplett wrote:
>
> The kernel already has this information, and individual drivers
> shouldn't duplicate that. This also eliminates the use of __DATE__ and
> __TIME__, which make the build non-deterministic.
>
> Signed-off-by: Josh Triplett <josh@joshtriplett.org>

(+cc Dinh Nguyen)

It looks good. :-)
Reviewed-by: Jingoo Han <jg1.han@samsung.com>

Best regards,
Jingoo Han

> ---
> drivers/mtd/nand/denali_pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/denali_pci.c b/drivers/mtd/nand/denali_pci.c
> index 033f177..ab64416 100644
> --- a/drivers/mtd/nand/denali_pci.c
> +++ b/drivers/mtd/nand/denali_pci.c
> @@ -131,7 +131,6 @@ static struct pci_driver denali_pci_driver = {
>
> static int denali_init_pci(void)
> {
> - pr_info("Spectra MTD driver built on %s @ %s\n", __DATE__, __TIME__);
> return pci_register_driver(&denali_pci_driver);
> }
> module_init(denali_init_pci);
> --
> 1.8.5.2



\
 
 \ /
  Last update: 2013-12-26 09:41    [W:0.056 / U:1.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site