Messages in this thread Patch in this message | | | Date | Wed, 29 Jan 2014 11:22:11 -0500 | From | Dave Jones <> | Subject | ocrdma: missing break in switch statement. |
| |
I've been going through the 'missing break' warnings in coverity, and there's a bunch in infiniband. A lot look intentional, but this one can't be right. We set a variable, and then immediately overwrite it.
instead of adding break spaghetti, just return the correct value.
Signed-off-by: Dave Jones <davej@fedoraproject.org>
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c index 1664d648cbfc..b45b7f8d9103 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c @@ -234,9 +234,9 @@ static int ocrdma_get_mbx_errno(u32 status) case OCRDMA_MBX_STATUS_FAILED: switch (add_status) { case OCRDMA_MBX_ADDI_STATUS_INSUFFICIENT_RESOURCES: - err_num = -EAGAIN; - break; + return -EAGAIN; } + default: err_num = -EFAULT; }
| |